fix: ensure store item picker registers picker:open on first open#2001
Merged
willeastcott merged 3 commits intomainfrom Apr 13, 2026
Merged
fix: ensure store item picker registers picker:open on first open#2001willeastcott merged 3 commits intomainfrom
willeastcott merged 3 commits intomainfrom
Conversation
The store item panel was created with hidden=false (the PCUI default), so the first open never triggered a hidden transition and the 'show' event never fired. This meant picker:open was never registered, causing a "picker:close fired for already closed picker storeitem" warning when navigating back with the back arrow. Fix by creating the panel with hidden:true and explicitly setting hidden=false after appending, so the transition fires 'show' and registers picker:open. Made-with: Cursor
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Contributor
There was a problem hiding this comment.
Pull request overview
Fixes an event-tracking mismatch in the Store item picker by ensuring the panel’s first “open” produces a real hidden: true -> false transition, so picker:open is emitted before a corresponding picker:close.
Changes:
- Initialize the Store item picker panel with
hidden: trueto force a first-time show transition. - After appending the panel into the store UI, explicitly set
hidden = falseto trigger theshowevent and registerpicker:open.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
hidden=false(the PCUI default), so the first open never triggered ahiddentransition — theshowevent never fired andpicker:openwas never registered in the picker tracking systemhidden: trueand explicitly setshidden = falseafter appending, ensuring theshowevent fires andpicker:openis properly paired withpicker:close