fix: guard store grid image load callback against destroyed container#2002
Merged
willeastcott merged 1 commit intomainfrom Apr 13, 2026
Merged
fix: guard store grid image load callback against destroyed container#2002willeastcott merged 1 commit intomainfrom
willeastcott merged 1 commit intomainfrom
Conversation
When rapidly switching between store tabs, itemsContainer.clear() destroys grid items while their thumbnail images are still loading. The late load callback then crashes calling appendChild on the nulled DOM. Adding a destroyed check prevents the race. Made-with: Cursor
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Contributor
There was a problem hiding this comment.
Pull request overview
Fixes a race condition in the asset store picker grid where thumbnail load events can fire after the grid item container has been destroyed (e.g., when rapidly switching store tabs), leading to a DOM append on a nulled container.
Changes:
- Added a
gridItem.destroyedearly-return guard inside the thumbnailloadhandler to prevent stale UI mutations after teardown.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
TypeError: Cannot read properties of null (reading 'appendChild').itemsContainer.clear()destroys grid item containers while thumbnail images are still loading. When theloadcallback fires on a destroyed container,Container.append()crashes because the backing DOM has been nulled. AgridItem.destroyedguard prevents the stale callback from executing.