Skip to content

[FIX] Sanitize empty scene_id before sending to Sentry#2005

Merged
kpal81xd merged 1 commit intomainfrom
fix/sanitize-sentry-scene-id
Apr 14, 2026
Merged

[FIX] Sanitize empty scene_id before sending to Sentry#2005
kpal81xd merged 1 commit intomainfrom
fix/sanitize-sentry-scene-id

Conversation

@kpal81xd
Copy link
Copy Markdown
Contributor

What's Changed

  • Fallback scene_id to -1 in Sentry tags when config.scene.id is an empty string, null, or undefined
  • Applied to both setSentryTags call sites that include scene_id (src/editor/editor.ts and src/launch/editor.ts)

Context

When no scene is found, the backend sets config.scene.id to ''. This empty string was flowing into Sentry tags unsanitized, producing misleading error reports (e.g. NS_ERROR_FAILURE events with invalid scene_id values).

Checks

@kpal81xd kpal81xd self-assigned this Apr 14, 2026
@vercel
Copy link
Copy Markdown

vercel Bot commented Apr 14, 2026

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
editor Ready Ready Preview, Comment Apr 14, 2026 1:36pm

Request Review

@kpal81xd kpal81xd added the bug Something isn't working label Apr 14, 2026
@kpal81xd kpal81xd merged commit 7b67c22 into main Apr 14, 2026
8 checks passed
@kpal81xd kpal81xd deleted the fix/sanitize-sentry-scene-id branch April 14, 2026 13:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant