[FIX] Buffer realtime ops arriving before asset registration#2007
Merged
[FIX] Buffer realtime ops arriving before asset registration#2007
Conversation
During bulk asset loading, ShareDB ops can arrive for assets that haven't been added to the editor registry yet. Buffer these ops and replay them once the asset is registered, preventing silent data loss in collaborative editing sessions.
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PLAY-CANVAS-G2XR — 135 events in
release:2.20.*What's Changed
loadAllAndSubscribe), ShareDB ops can arrive for assets that haven't been added to the editor registry yet. Therealtime:op:assetshandler callsassets:getUniquewhich returns null, silently dropping the op and leaving local editor state stale for collaborative sessions.Map, replay them once the asset is added and itsObserverSyncis initialized, and clear the buffer on disconnect/reconnect.src/editor/assets/assets-sync.ts) and launch (src/launch/assets/assets-sync.ts) variants.Checks