Text-element render sub-range #1585
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
slimbuck
requested review from
daredevildave,
e-strokov,
vkalpias and
willeastcott
|
|
||
| // calculate the number of characters per texture up to, but not including | ||
| // the specified symbolIndex | ||
| _calculateCharsPerTexture: function (symbolIndex) { |
Contributor
There was a problem hiding this comment.
symbolIndex arg doesn't seem to be used can we remove it?
Member
Author
There was a problem hiding this comment.
Not sure I understand... symbolIndex is used in the function and two of the function callsites...
daredevildave
approved these changes
Jun 4, 2019
willeastcott
approved these changes
Jun 5, 2019
Contributor
|
Can you add some API ref docs for the two new properties please? 😄 |
Member
Author
|
text-element.js currently has no API docs at all. Should I add the API docs as private or..? |
Contributor
|
Oh, looks like you haven't exposed the properties to pc.ElementComponent. Look at, say, enableMarkup for an example. |
Contributor
|
And the docs for these properties should be public. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1584
I confirm I have signed the Contributor License Agreement.