Skip to content

Extracted LightsBuffer class from WorldClusters#3600

Merged
mvaligursky merged 2 commits into
masterfrom
mvaligursky-clustered-refactor
Oct 22, 2021
Merged

Extracted LightsBuffer class from WorldClusters#3600
mvaligursky merged 2 commits into
masterfrom
mvaligursky-clustered-refactor

Conversation

@mvaligursky

@mvaligursky mvaligursky commented Oct 21, 2021 •
edited
Loading

Copy link
Copy Markdown
Contributor
  • refactoring with no functionality changed, as WorldClusters was getting complicated
  • move WorldClusters to a lighting folder now that other PRs were merged
  • Extracted LightsBuffer class which handles encoding of light properties in texture buffers from WorldClusters class, which handles light placement in the cluster cells.

@mvaligursky mvaligursky self-assigned this Oct 21, 2021
@mvaligursky mvaligursky added the area: graphics Graphics related issue label Oct 21, 2021
@mvaligursky mvaligursky requested a review from a team October 21, 2021 13:48
@willeastcott

willeastcott commented Oct 21, 2021

Copy link
Copy Markdown
Contributor

Big improvement - so glad that mega-function is gone! 😄

Merge branch 'master' into mvaligursky-clustered-refactor
842d854 
# Conflicts:
#	src/scene/composition/layer-composition.js
@mvaligursky mvaligursky merged commit 46948d9 into master Oct 22, 2021
@mvaligursky mvaligursky deleted the mvaligursky-clustered-refactor branch October 22, 2021 17:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@willeastcott willeastcott willeastcott approved these changes

Assignees

@mvaligursky mvaligursky

Labels

area: graphics Graphics related issue

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@mvaligursky @willeastcott