Skip to content

[BREAKING] Removed support for VSM8 shadow type#7146

Merged
mvaligursky merged 3 commits intomainfrom
mv-remove-vsm8
Nov 27, 2024
Merged

[BREAKING] Removed support for VSM8 shadow type#7146
mvaligursky merged 3 commits intomainfrom
mv-remove-vsm8

Conversation

@mvaligursky
Copy link
Copy Markdown
Contributor

@mvaligursky mvaligursky commented Nov 27, 2024 •
edited
Loading

  • due to low quality / incorrect rendering, this has been removed as this was mostly a fallback for WebGL1 devices
  • if project depends on it, it should be switched to VSM16 which is well supported on WebGL2 devices, and fallbacks for PCF3

@mvaligursky mvaligursky self-assigned this Nov 27, 2024
@mvaligursky mvaligursky added area: graphics Graphics related issue enhancement labels Nov 27, 2024
@mvaligursky mvaligursky requested a review from a team November 27, 2024 14:54
slimbuck
slimbuck approved these changes Nov 27, 2024
View reviewed changes
Copy link
Copy Markdown
Member

@slimbuck slimbuck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

are there any data migration consequences?

@mvaligursky mvaligursky mentioned this pull request Nov 27, 2024
Closed
@mvaligursky
Copy link
Copy Markdown
Contributor Author

mvaligursky commented Nov 27, 2024

are there any data migration consequences?

perhaps. Needed work is captured here: playcanvas/editor#1233

@mvaligursky mvaligursky merged commit c869024 into main Nov 27, 2024
@mvaligursky mvaligursky deleted the mv-remove-vsm8 branch November 27, 2024 15:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@slimbuck slimbuck slimbuck approved these changes

Assignees

@mvaligursky mvaligursky

Labels

area: graphics Graphics related issue

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@mvaligursky @slimbuck