Skip to content

[Fix] Fix frequent shader variant invalidation#7294

Merged
mvaligursky merged 1 commit intomainfrom
mv-variants-invalidation
Jan 20, 2025
Merged

[Fix] Fix frequent shader variant invalidation#7294
mvaligursky merged 1 commit intomainfrom
mv-variants-invalidation

Conversation

@mvaligursky
Copy link
Contributor

@mvaligursky mvaligursky commented Jan 17, 2025

Fix long term problem made worse in #7284

Basically:

  • Material.chunks getter marks material as dirty, not only setter, as we don't know if chunks will be modified even then
  • ShadowRenderer calls this getter, even though it only tests for its existence, invalidating variants
  • now that all materials have chunks, this test can be removed

@mvaligursky mvaligursky merged commit 1923eb6 into main Jan 20, 2025
7 checks passed
@mvaligursky mvaligursky deleted the mv-variants-invalidation branch January 20, 2025 09:48
mvaligursky added a commit that referenced this pull request Jan 20, 2025
Co-authored-by: Martin Valigursky <mvaligursky@snapchat.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area: graphics Graphics related issue

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants