[Fix] Texture created by TextureAtlas respects its initial settings#7300
Merged
mvaligursky merged 1 commit intomainfrom Jan 20, 2025
Merged
[Fix] Texture created by TextureAtlas respects its initial settings#7300mvaligursky merged 1 commit intomainfrom
mvaligursky merged 1 commit intomainfrom
Conversation
willeastcott
approved these changes
Jan 20, 2025
mvaligursky
added a commit
that referenced
this pull request
Jan 20, 2025
…7300) Co-authored-by: Martin Valigursky <mvaligursky@snapchat.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
TextureAtlas under the hood creates a Texture by calling Open on its handler. We now pass an asset instance to it, allowing it to create the texture using initial settings, instead of depending on those settings to be set on Texture after the creation, which is currently not supported on WebGPU.
Fixes a warning during loading of https://playcanvas.com/project/1295667/overview/webgpu-mips-warning