Conversation
Contributor
kpal81xd
commented
May 30, 2025
kpal81xd
commented
- Adds methods for dot product and linear lerping between two quaternions
| * result.lerp(q1, q2, 0.5); // Return the midpoint interpolant | ||
| * result.lerp(q1, q2, 1); // Return q2 | ||
| */ | ||
| lerp(lhs, rhs, alpha) { |
Contributor
There was a problem hiding this comment.
Uhm. Why would you ever lerp quaternions instead of slerp them?
Contributor
Author
There was a problem hiding this comment.
Lerping is less expensive than performing a slerp
willeastcott
approved these changes
May 30, 2025
Contributor
|
@kpal81xd Minor point but adding these kinds of functions should also include unit tests (easily done with ChatGPT). |
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.