[Fix] Re-render all shadows when the device context is restored#7757
Merged
mvaligursky merged 1 commit intomainfrom Jun 12, 2025
Merged
[Fix] Re-render all shadows when the device context is restored#7757mvaligursky merged 1 commit intomainfrom
mvaligursky merged 1 commit intomainfrom
Conversation
slimbuck
approved these changes
Jun 12, 2025
Comment on lines
+124
to
+128
|
|
||
| // don't stringify EventHandle to JSON by JSON.stringify | ||
| toJSON(key) { | ||
| return undefined; | ||
| } |
Contributor
There was a problem hiding this comment.
Why was this causing a problem? Does this really belong in this PR?
Contributor
Author
There was a problem hiding this comment.
It does. As part of the shader options file, we serialize light properties .. and light now has the new event handler I added, and this excludes it from being serialized there, otherwise serialize was failing due to some circular reference.
Contributor
Author
There was a problem hiding this comment.
I added this to GraphicsDevice back then for the same reason - lots of device properties were serialized with the light.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When the device is restored, shadow maps that are of type
SHADOWUPDATE_THISFRAMEtypically have shadow already rendered in the past, and are now set toSHADOWUPDATE_NONE. We now set them toSHADOWUPDATE_THISFRAMEmaking the shadows to re-render.