Fix SOG SH decompression #8271
Merged
Fix SOG SH decompression #8271
+11
−12
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
slimbuck
added
bug
willeastcott
approved these changes
Dec 19, 2025
Contributor
There was a problem hiding this comment.
Pull request overview
This PR fixes a bug in SOG SH (Spherical Harmonics) decompression that was introduced in PR #8215. The issue occurred when the decompress option was enabled - the shBands property was not being calculated because it was only computed in prepareGpuData(), which wasn't called during decompression.
- Refactored
shBandsfrom a private cached property to a public property - Extracted band calculation logic into a static
calcBands()method - Ensured
shBandsis set in both parsers before decompression or GPU preparation
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| src/scene/gsplat/gsplat-sogs-data.js | Changed _shBands to public shBands property, added static calcBands() method, removed getter that was previously caching the value in prepareGpuData() |
| src/framework/parsers/sogs.js | Added call to set shBands using the new static method before decompression path |
| src/framework/parsers/sog-bundle.js | Added call to set shBands using the new static method before decompression path |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
mvaligursky
approved these changes
Dec 19, 2025
mvaligursky
pushed a commit
that referenced
this pull request
Dec 19, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Broken in #8215.