ES2020 compatibility for GSplatSortBinWeights worker injection #8373
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes gsplat sorting not working in release builds when targeting ES2020.
Problem
When SWC transpiles to ES2020, static class fields are moved outside the class body:
Since
GSplatSortBinWeightsis stringified via.toString()and injected into a web worker, the static properties were lost after transpilation. This causedNUM_BINSandWEIGHT_TIERSto beundefinedin the worker, breaking the sorting algorithm.Solution
Convert static class fields to static getters, which are ES2015 syntax and remain inside the class body when stringified:
Testing
npm run build && npm run serve