Fix preprocessor numeric literal parsing to avoid incorrect partial matches #8404
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes an edge case where expressions starting with numbers could be incorrectly parsed as numeric literals.
Problem
The numeric literal check using
parseFloat(expr)could produce incorrect results for expressions containing comparison operators. For example,#if 3 == 3would be parsed asparseFloat("3 == 3")which returns3(parseFloat stops at the first non-numeric character), causing the expression to incorrectly evaluate to true.Solution
Use a strict regex (
/^\d+(?:\.\d+)?$/) that only matches pure numeric literals, ensuring expressions like3 == 3or0 != 1don't get incorrectly parsed as numbers.Test Plan
#if 3 == 3,#if 0 != 1,#if 5 > 3)