Only emit written color outputs in WGSL FragmentOutput struct#8465
Merged
slimbuck merged 3 commits intoplaycanvas:mainfrom Feb 20, 2026
Merged
Only emit written color outputs in WGSL FragmentOutput struct#8465slimbuck merged 3 commits intoplaycanvas:mainfrom
slimbuck merged 3 commits intoplaycanvas:mainfrom
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR fixes WebGPU validation errors that occur when fragment shaders declare color output locations they never assign to. The WGSL shader processor is updated to conditionally emit color outputs in the FragmentOutput struct based on whether the shader actually writes to them, matching the existing pattern used for fragDepth.
Changes:
- Modified
generateFragmentOutputStructto scan shader source for color output assignments before including them in the struct - Uses regex pattern matching to detect
.color =,.color1 =, etc. assignments in the shader source
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
willeastcott
approved these changes
Feb 20, 2026
mvaligursky
pushed a commit
that referenced
this pull request
Feb 24, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The WGSL shader processor previously included all color output members in the
FragmentOutputstruct based onnumRenderTargets, regardless of whether theshader actually writes to them. This can cause WebGPU validation errors when a
fragment shader declares an output location it never assigns to.
This change updates
generateFragmentOutputStructto scan the shader source foractual assignments (e.g.
.color =,.color1 =) and only emit@locationmembers for outputs that are written, matching the existing pattern already used
for
fragDepth.Changes
WebgpuShaderProcessorWGSL.generateFragmentOutputStructnow filters coloroutputs by checking if the shader source contains an assignment to each color
member before including it in the struct