fix: preserve blend state in drawQuadWithShader / RenderPassQuad#8535
Merged
mvaligursky merged 1 commit intomainfrom Mar 19, 2026
Merged
fix: preserve blend state in drawQuadWithShader / RenderPassQuad#8535mvaligursky merged 1 commit intomainfrom
mvaligursky merged 1 commit intomainfrom
Conversation
RenderPassQuad.execute() was calling device.setDrawStates() with no arguments, which defaults blendState to BlendState.NOBLEND. This overwrites any blend state the caller set before drawQuadWithShader(), breaking custom blending in post effects. Pass device.blendState through to preserve the caller's blend state while still resetting depth, cull, frontFace, and stencil to safe defaults. This restores the pre-setDrawStates behavior where blend state was not touched by RenderPassQuad. Fixes https://forum.playcanvas.com/t/drawquadwithshader-does-not-work-with-blendstate/42066 Made-with: Cursor
mvaligursky
added a commit
that referenced
this pull request
Mar 19, 2026
RenderPassQuad.execute() was calling device.setDrawStates() with no arguments, which defaults blendState to BlendState.NOBLEND. This overwrites any blend state the caller set before drawQuadWithShader(), breaking custom blending in post effects. Pass device.blendState through to preserve the caller's blend state while still resetting depth, cull, frontFace, and stencil to safe defaults. This restores the pre-setDrawStates behavior where blend state was not touched by RenderPassQuad. Fixes https://forum.playcanvas.com/t/drawquadwithshader-does-not-work-with-blendstate/42066 Made-with: Cursor Co-authored-by: Martin Valigursky <mvaligursky@snapchat.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes a regression introduced in #8503 where
RenderPassQuad.execute()callsdevice.setDrawStates()with no arguments, which defaultsblendStatetoBlendState.NOBLEND. This overwrites any blend state the caller set beforedrawQuadWithShader(), breaking custom blending in post effects.Changes:
device.blendStatethrough tosetDrawStates()inRenderPassQuad, preserving the caller's blend state while still resetting depth, cull, frontFace, and stencil to safe defaultsRenderPassQuadFixes https://forum.playcanvas.com/t/drawquadwithshader-does-not-work-with-blendstate/42066