fix: round up compressed texture dimensions to block size on WebGPU#8540
Merged
mvaligursky merged 1 commit intomainfrom Mar 20, 2026
Merged
fix: round up compressed texture dimensions to block size on WebGPU#8540mvaligursky merged 1 commit intomainfrom
mvaligursky merged 1 commit intomainfrom
Conversation
WebGPU requires compressed texture dimensions to be multiples of the block size (4 for BC, ETC2, ASTC 4x4). Textures with non-aligned dimensions (e.g. 2x2) cause a GPU validation error and crash, particularly on iOS/Safari. Round up dimensions automatically and log a Debug.error to inform the developer. Made-with: Cursor
Contributor
There was a problem hiding this comment.
Pull request overview
Fixes a WebGPU validation/crash issue by ensuring GPU texture creation complies with WebGPU’s requirement that compressed texture dimensions be block-aligned (4x4 for the currently supported compressed formats).
Changes:
- Detects WebGPU compressed textures whose dimensions are not multiples of 4 and rounds them up.
- Emits a
Debug.errordescribing the issue and the auto-fix being applied.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
WebGPU requires compressed texture dimensions to be multiples of the block size (4x4 for BC, ETC2, ASTC 4x4). Textures with smaller dimensions (e.g. 2x2) cause a GPU validation error and crash, particularly on iOS/Safari. This is not an issue on WebGL which handles sub-block sizes internally.
Changes:
Debug.errorexplaining the issue and the automatic fixRelated to: https://forum.playcanvas.com/t/webgpu-fails-on-ios-safari/42070