fix: replace StopThePop tile intersection with exact FlashGS method in compute GSplat#8548
Merged
mvaligursky merged 1 commit intomainfrom Mar 24, 2026
Merged
Conversation
The StopThePop closest-point approximation produced grid artifacts on larger splats due to false negatives for elongated ellipses. The FlashGS exact conic-edge intersection is both more correct and slightly faster (~1.4ms vs ~1.5ms tile-count pass on 12M splats). Fixed #8531 Made-with: Cursor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replace the StopThePop closest-point tile intersection test with the exact FlashGS conic-edge intersection method in the compute GSplat renderers.
Changes:
Performance:
Avoids issues like this in some specific cases (elongated splats)
