refactor: extract GSplatFrustumCuller from GSplatWorkBuffer#8560
Merged
mvaligursky merged 2 commits intomainfrom Mar 30, 2026
Merged
refactor: extract GSplatFrustumCuller from GSplatWorkBuffer#8560mvaligursky merged 2 commits intomainfrom
mvaligursky merged 2 commits intomainfrom
Conversation
Move the frustum culling subsystem (bounding-sphere textures, transforms texture, node visibility texture, culling render pass, and related methods) out of GSplatWorkBuffer into a dedicated GSplatFrustumCuller class. GSplatWorkBuffer now owns a frustumCuller instance and GSplatManager accesses culling through it. Made-with: Cursor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Extract the frustum culling subsystem from
GSplatWorkBufferinto a dedicatedGSplatFrustumCullerclass, simplifying the work buffer and clarifying responsibilities.Changes:
GSplatFrustumCullerclass (gsplat-frustum-culler.js) that owns all culling-related GPU resources: bounding-sphere texture, transform-index texture, transforms texture, node visibility texture, culling render target and render passupdateBoundsTexture,updateTransformsTexture, andupdateNodeVisibilitymethods fromGSplatWorkBuffertoGSplatFrustumCullerGSplatWorkBuffernow owns afrustumCullerinstance, created in its constructor and destroyed on cleanupGSplatManagercall sites to access culling throughworkBuffer.frustumCuller