fix: pass alphaClip to scatter pass instead of hardcoding 1/255#8564
Merged
mvaligursky merged 1 commit intomainfrom Mar 31, 2026
Merged
fix: pass alphaClip to scatter pass instead of hardcoding 1/255#8564mvaligursky merged 1 commit intomainfrom
mvaligursky merged 1 commit intomainfrom
Conversation
The scatter pass hardcoded alphaClip to 1/255 for radius computation while the tile count pass used the actual uniform value. In pick mode (alphaClip=0.3), this caused scatter to use a wider radius than tile count, potentially overflowing tile allocations and silently dropping splat assignments near tile boundaries. Made-with: Cursor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes a mismatch between the tile count and scatter passes where the scatter shader hardcoded
alphaClipto1.0/255.0while the tile count pass used the actual uniform value.Changes:
alphaClipuniform to the scatter shader, replacing the hardcoded1.0 / 255.0incomputeSplatTileEvalalphaClipvalue from JS to both tile count and scatter passesIn pick mode (
alphaClip = 0.3), tile count computed a tighter radius (fewer tiles) while scatter used1/255producing a wider radius (more tiles). This caused scatter to try assigning splats to tiles with insufficient allocated capacity, silently dropping assignments near tile boundaries via the bounds check.