Remove centers array dependency from GSplatInfo interval check#8568
Merged
mvaligursky merged 1 commit intomainfrom Apr 1, 2026
Merged
Remove centers array dependency from GSplatInfo interval check#8568mvaligursky merged 1 commit intomainfrom
mvaligursky merged 1 commit intomainfrom
Conversation
Use resource.maxSplats instead of resource.centers?.length / 3 to determine total splat capacity. This removes the only non-CPU-sort access to the centers Float32Array, allowing it to be skipped for GPU sort and compute renderers in the future. Made-with: Cursor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Remove the only non-CPU-sort access to the
centersFloat32Array fromGSplatInfo, replacingresource.centers?.length / 3withresource.maxSplatsto determine total splat capacity for the active-splat interval check.Changes:
resource.maxSplats(already exposed byGSplatContainer) instead of reading thecentersarray length inGSplatInfo.updateIntervalsGSplatContainerresources, behavior is identical —maxSplatsreturns the same pre-allocated capacity valuemaxSplatsisundefined(falsy), so the block is skipped — same as before sinceactiveSplatsalways equaled the total countPerformance:
centersFloat32Array, enabling future work to skip allocating this ~114 MB buffer (for 10M splats) when using GPU sort or compute renderers