fix: match raster minPixelSize culling threshold in compute GSplat renderer#8569
Merged
mvaligursky merged 1 commit intomainfrom Apr 1, 2026
Merged
fix: match raster minPixelSize culling threshold in compute GSplat renderer#8569mvaligursky merged 1 commit intomainfrom
mvaligursky merged 1 commit intomainfrom
Conversation
…nderer The compute tile-count shader compared `sqrt(2*a)` against minPixelSize, while the raster vertex shader compared `2*sqrt(2*lambda)` — a 2x factor difference. Scale the uniform by 0.5 on the CPU side so both paths cull at the same effective screen-space threshold. Made-with: Cursor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix minPixelSize culling threshold mismatch between the compute and raster GSplat renderers.
Changes:
minPixelSizeuniform by 0.5 when passing it to the compute tile-count shader, aligning it with the raster vertex shader's convention where the pixel size metric is2.0 * radiusrather than justradiusMade with Cursor