Skip to content

Move FisheyeProjection to scene/graphics for shared use#8588

Merged
mvaligursky merged 1 commit intomainfrom
mv-move-fisheye-projection
Apr 10, 2026
Merged

Move FisheyeProjection to scene/graphics for shared use#8588
mvaligursky merged 1 commit intomainfrom
mv-move-fisheye-projection

Conversation

@mvaligursky
Copy link
Copy Markdown
Contributor

Move FisheyeProjection out of gsplat-unified into scene/graphics, since it is also used by skybox rendering.

Changes:

  • Move fisheye-projection.js from src/scene/gsplat-unified/ to src/scene/graphics/
  • Update imports in gsplat renderer and skybox

@mvaligursky mvaligursky self-assigned this Apr 10, 2026
@mvaligursky mvaligursky merged commit d212009 into main Apr 10, 2026
8 checks passed
@mvaligursky mvaligursky deleted the mv-move-fisheye-projection branch April 10, 2026 15:57
@willeastcott
Copy link
Copy Markdown
Contributor

Doesn't this feel more like a Camera property?

@mvaligursky
Copy link
Copy Markdown
Contributor Author

In a way, but only two systems honor it (unified gsplat & infinite skydome), nothing else. Geometry, particles, UI, debug lines ... , none of that.

@LeXXik
Copy link
Copy Markdown
Contributor

LeXXik commented Apr 10, 2026

Feels like a camera thingy, though

@mvaligursky
Copy link
Copy Markdown
Contributor Author

Feels like a camera thingy, though

Might feel like it, but it's not :)
Even camera matrices are not updated to handle this in any way,
This is a custom implementation in two shaders.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants