fix: suppress frame:ready until full LOD update after param changes#8602
Merged
mvaligursky merged 1 commit intomainfrom Apr 15, 2026
Merged
fix: suppress frame:ready until full LOD update after param changes#8602mvaligursky merged 1 commit intomainfrom
mvaligursky merged 1 commit intomainfrom
Conversation
When gsplat params change (e.g. splatBudget), the frame:ready event could report ready=true before the LOD system had fully reacted — especially with GPU sorting where sortedVersion catches up in the same frame. This made it impossible for consumers to reliably detect the not-ready→ready transition. Add _awaitingLodUpdate flag that suppresses ready=true until a fullUpdate cycle runs (which polls load completions and re-evaluates LODs). The flag is only set when octree instances exist, so non-streaming scenarios are unaffected.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When gsplat params change (e.g.
splatBudget), theframe:readyevent could reportready=truebefore the LOD system had fully reacted — especially with GPU sorting wheresortedVersioncatches up in the same frame. This made it impossible for consumers to reliably detect the not-ready→ready transition after param changes.Changes:
_awaitingLodUpdateflag onGSplatManagerthat suppressesready=truein theframe:readyevent until afullUpdatecycle runs (which polls load completions and re-evaluates LODs)dirtyis detected inupdate(), cleared at end offullUpdateblockThis enables a reliable two-phase wait pattern: wait for
ready=false(system reacted), then wait forready=true && loadingCount===0(fully stabilized).