Skip to content

Decouple compute GSplat renderer from work buffer via setDataSource#8605

Merged
mvaligursky merged 1 commit intomainfrom
mv-compute-renderer-datasource
Apr 16, 2026
Merged

Decouple compute GSplat renderer from work buffer via setDataSource#8605
mvaligursky merged 1 commit intomainfrom
mv-compute-renderer-datasource

Conversation

@mvaligursky
Copy link
Copy Markdown
Contributor

Decouples GSplatComputeLocalRenderer from GSplatWorkBuffer by introducing a setDataSource API, allowing the compute renderer to work with any object providing { format, getTexture(name) }.

Changes:

  • Add setDataSource(source) to GSplatRenderer base class — updates workBuffer and notifies derived classes of format changes
  • Override setDataSource in GSplatComputeLocalRenderer to store an independent _dataSource reference, fully decoupling from the work buffer
  • Replace all direct this.workBuffer access in the compute renderer with this._dataSource
  • Update GSplatManager.handleFormatChange to use setDataSource instead of direct property assignment
  • Allow null workBuffer in the base class constructor for standalone compute renderer usage

API Changes:

  • GSplatRenderer.setDataSource(source) — new method to set the data source for format and texture access
  • GSplatComputeLocalRenderer.setDataSource(source) — override that accepts any { format: GSplatFormat, getTexture: (name) => Texture } object
  • The compute renderer can now be constructed without a work buffer and used standalone with a custom data source

…taSource

Introduces a setDataSource API on GSplatRenderer, allowing the compute
renderer to work with any object providing { format, getTexture(name) }
instead of requiring a GSplatWorkBuffer directly.
@mvaligursky mvaligursky self-assigned this Apr 16, 2026
@mvaligursky mvaligursky added the area: graphics Graphics related issue label Apr 16, 2026
@mvaligursky mvaligursky merged commit bedf341 into main Apr 16, 2026
8 checks passed
@mvaligursky mvaligursky deleted the mv-compute-renderer-datasource branch April 16, 2026 14:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area: graphics Graphics related issue

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant