Skip to content

Replace share buttons with save buttons in GSplat benchmark example#8608

Merged
mvaligursky merged 1 commit intomainfrom
mv-benchmark-save-buttons
Apr 16, 2026
Merged

Replace share buttons with save buttons in GSplat benchmark example#8608
mvaligursky merged 1 commit intomainfrom
mv-benchmark-save-buttons

Conversation

@mvaligursky
Copy link
Copy Markdown
Contributor

Replaces the two "Share" buttons in the GSplat benchmark example with direct "Save" buttons, since navigator.share with files is unsupported on most desktop browsers.

Changes:

  • "Share Results" → "Save Results (.txt)" — always downloads the results as a .txt file
  • "Share Chart" → "Save Chart (.png)" — always downloads the chart as a .png file (now with a timestamped filename)
  • Removed navigator.share / navigator.canShare code paths

navigator.share with files is unsupported on most desktop browsers,
so always download directly instead.
@mvaligursky mvaligursky self-assigned this Apr 16, 2026
@mvaligursky mvaligursky merged commit 8db7b90 into main Apr 16, 2026
8 checks passed
@mvaligursky mvaligursky deleted the mv-benchmark-save-buttons branch April 16, 2026 19:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant