refactor: drop vendor-prefixed Page Visibility API support#8638
Merged
Conversation
The unprefixed `visibilitychange` event and `document.hidden` property are supported by all browsers the engine targets (WebGL 2 baseline). Remove the `moz`/`ms`/`webkit` fallbacks from AppBase and the now-unused `_hiddenAttr` internal property. Made-with: Cursor
Contributor
There was a problem hiding this comment.
Pull request overview
Removes legacy vendor-prefixed Page Visibility API handling from AppBase and standardizes visibility tracking on the unprefixed document.hidden + visibilitychange API.
Changes:
- Register only the unprefixed
visibilitychangelistener duringinit(). - Simplify
isHidden()to returndocument.hiddendirectly. - Simplify teardown in
destroy()by removing only the unprefixed listener (and implicitly removing the need for_hiddenAttr).
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
mozvisibilitychange,msvisibilitychange,webkitvisibilitychangeand the pairedmozHidden/msHidden/webkitHiddenattribute lookup) fromAppBase.visibilitychangelistener ininit(), tears it down with a singleremoveEventListenerindestroy(), and rewritesisHidden()to readdocument.hiddendirectly._hiddenAttrproperty.Rationale
The unprefixed Page Visibility API (
document.hidden+visibilitychange) is universally supported by the engine's target browsers (WebGL 2 baseline: Chrome 56+, Firefox 51+, Safari 15+, Edge 79+).keyboard.jsalready only uses the unprefixed event, so this bringsAppBasein line.Public API
AppBase#isHidden()— unchanged signature and return semantics, only the internal implementation changed._hiddenAttrwas private (underscore-prefixed, not a declared class field) and had no external consumers.Test plan
npx eslint src/framework/app-base.js— clean.