Fix Picker depth clear decoding#8651
Merged
mvaligursky merged 1 commit intoplaycanvas:mainfrom Apr 27, 2026
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Fixes depth decoding in Picker#getPointDepthAsync() so RGBA8-packed float bits are reconstructed as an unsigned 32-bit integer, ensuring cleared depth pixels (0xFFFFFFFF) are correctly treated as “no hit” and do not produce NaN world points.
Changes:
- Reconstruct RGBA8 depth bits as an unsigned 32-bit value using
>>> 0. - Restore the intended
0xFFFFFFFFcleared-depth sentinel behavior (returnsnull).
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
willeastcott
approved these changes
Apr 25, 2026
mvaligursky
approved these changes
Apr 27, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Picker#getPointDepthAsync()so RGBA8 depth bits are reconstructed as an unsigned 32-bit value.0xFFFFFFFF) are correctly treated as “no hit” instead of being reinterpreted asNaN.Details
JavaScript bitwise operations produce signed 32-bit integers. For a cleared depth pixel
[255, 255, 255, 255], the previous decode produced-1, so the0xFFFFFFFFno-depth check failed. This could cause background picks to return aNaNworld point.The fix applies
>>> 0after reconstructing the integer bits.Test Plan
nullinstead of aNaNworld point.