refactor(light): align LightComponent with CameraComponent architecture

[willeastcott]

Summary

Refactor LightComponent to mirror CameraComponent's architecture, paving the way for eliminating *ComponentData classes engine-wide.

• LightComponent now owns its Light instance (_light) directly and constructs it in its own constructor, mirroring how CameraComponent owns _camera.
• Every property is either a direct delegate to this._light or backed by a small private field on the component. Properties no longer round-trip through data[name] and the _setValue helper has been removed.
• LightComponentData is reduced to a single enabled field. The properties export is gone.
• LightComponentSystem matches CameraComponentSystem: _schema = ['enabled'], explicit property lists drive initializeComponentData and cloneComponent, and Component._buildAccessors(LightComponent.prototype, _schema) handles the enabled accessor. The previous changeType system method was a one-liner with no system state and is now inlined into the component's type setter, so the system is pure boilerplate.

Public API

No additions, removals, or behaviour changes. The full property surface of LightComponent is preserved (verified against the regenerated .d.ts), including round-tripping 'point' as 'point' (rather than normalising it to 'omni').

Test plan

• npm run lint passes
• npm run build:types regenerates .d.ts cleanly; npm run test:types passes
• npm test — 1653 passing, 0 failing

[Copilot]

Pull request overview

Refactors LightComponent to mirror CameraComponent’s architecture by having the component directly own and manage its underlying Light instance, reducing reliance on *ComponentData property bags.

Changes:

• LightComponent now constructs/owns this._light and delegates most accessors directly to it; _setValue and data[name] round-tripping are removed.
• LightComponentData is reduced to enabled only; LightComponentSystem uses _schema = ['enabled'] and an explicit property list for init/clone.
• Adds lightTypeNames reverse lookup (and export) to support normalized LightComponent.type getter behavior; updates entity test expectation to 'omni'.

Reviewed changes

Copilot reviewed 4 out of 4 changed files in this pull request and generated 1 comment.

Show a summary per file

File	Description
test/framework/entity.test.mjs	Updates assertion to match normalized light type read-back ('omni').
src/scene/light.js	Adds/export lightTypeNames reverse map for light type string getters.
src/framework/components/light/system.js	Aligns system with CameraComponentSystem pattern: schema-only enabled, explicit init/clone via _properties.
src/framework/components/light/data.js	Shrinks data class to enabled only, removing legacy property bag.
src/framework/components/light/component.js	Moves Light ownership into component and rewires accessors to delegate to this._light / small private fields.

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

[Copilot]

Pull request overview

Copilot reviewed 4 out of 4 changed files in this pull request and generated 1 comment.

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

[Copilot]

Pull request overview

Copilot reviewed 4 out of 4 changed files in this pull request and generated 2 comments.

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

[Copilot]

Pull request overview

Copilot reviewed 4 out of 4 changed files in this pull request and generated 2 comments.

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

[Copilot]

Pull request overview

Copilot reviewed 4 out of 4 changed files in this pull request and generated no new comments.

Comments suppressed due to low confidence (1)

src/framework/components/light/component.js:1318

• refreshProperties() reassigns layers (this.layers = this.layers), which with the current layers setter triggers a full remove/re-add across all layers, and then refreshProperties() calls onEnable() which adds the light to layers again. Since refreshProperties() is only used from the type setter, consider skipping layers in the refresh loop and handling layer re-add explicitly in the type setter (or otherwise ensure the type change only does one remove + one add) to avoid redundant layer bookkeeping.

    refreshProperties() {
        for (let i = 0; i < _properties.length; i++) {
            const name = _properties[i];

            /* eslint-disable no-self-assign */
            this[name] = this[name];
            /* eslint-enable no-self-assign */
        }
        if (this.enabled && this.entity.enabled) {
            this.onEnable();
        }

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.