refactor(button): remove redundant constructor assignments in ButtonComponent#8669
Merged
Conversation
…omponent Co-authored-by: Cursor <cursoragent@cursor.com>
Contributor
There was a problem hiding this comment.
Pull request overview
This PR performs an internal cleanup in ButtonComponent by removing redundant constructor assignments for fields that are already initialized via class field initializers, keeping the constructor focused on super() and lifecycle listener wiring.
Changes:
- Removed duplicate initialization of seven private state fields from the
ButtonComponentconstructor. - Kept constructor behavior limited to
super(system, entity)and_toggleLifecycleListeners('on', system).
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Remove dead duplicate field initialisations from the
ButtonComponentconstructor. The same seven fields (_visualState,_isHovering,_hoveringCounter,_isPressed,_defaultTint,_defaultSpriteAsset,_defaultSpriteFrame) are already declared as class fields with identical default values, so the constructor was writing them a second time.The constructor retains its
super()call and the lifecycle-listener wiring.Pure internal cleanup — no behavioral change, no public API change.
Test plan
npm run lint— passes (only the single pre-existing unrelated warning inutils/rollup-build-target.mjs).npm test— 1672 tests passing.