fix: TAA resolve premultiplied alpha for transparent clears (#8654)#8726
Merged
Conversation
Temporal blend and neighborhood clamp in premultiplied rgb*a space; output alpha from current frame only. Adds hidden test example and thumbnails.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #8654
TAA resolve now clamps and temporally blends in premultiplied `rgb * a` space, then un-premultiplies using the current frame alpha only (alpha is not averaged over time). This addresses coloured fringes and alpha-related ghosting when using transparent camera clears with `CameraFrame` TAA (`antialias: false`, `alpha: true`).
Changes:
API changes: None
Examples: `test/taa-alpha` (hidden)