refactor: tidy ResourceLoader.enableRetry defaults and input handling#8745
Merged
Conversation
Small follow-up to #8744 addressing review comments on ResourceLoader.enableRetry. - AppBase now calls this.loader.enableRetry() without arguments, so the default retry count (5) lives in a single place - the enableRetry signature - instead of being duplicated in AppBase. - enableRetry now floors maxRetries before clamping, so non-integer inputs produce a predictable number of attempts.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Small follow-up to #8744 addressing review comments on
ResourceLoader.enableRetry.Changes:
AppBasenow callsthis.loader.enableRetry()without arguments, so the default retry count (5) lives in a single place — theResourceLoader.enableRetrysignature — instead of being duplicated inAppBase.ResourceLoader.enableRetrynow floorsmaxRetriesbefore clamping, so non-integer inputs produce a predictable number of attempts (the underlyingHttpretry counter compares against an integer).