fix: resolve sog texture urls from document base#8754
Merged
Conversation
mvaligursky
approved these changes
May 21, 2026
Contributor
|
Will it work if the url doesn't use |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Resolve unpacked SOG child texture URL generation relative to document.baseURI when no asset.options.mapUrl override is provided.
meta.json requests can honor a page tag, but SogParser previously resolved sibling .webp files against window.location.href. The scope is limited to unpacked SOG fallback texture URL resolution; absolute URLs and asset.options.mapUrl behavior are unchanged.
Manual testing
Manual tests: not run. Browser validation recommended:
Checklist