fix(gsplat): gate ImageBitmap release on opt-in flag, make it one-shot#8760
Merged
Conversation
Address review feedback: - Texture.destroy() no longer closes ImageBitmaps unconditionally; only when the owner has opted in via setReleaseSourceAfterUpload. Avoids invalidating bitmaps shared across textures or with caller code. - releaseImageSources() now clears the flag, matching the documented "release after the next upload" semantics. Callers must re-arm if they assign a new source they want released.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #8758 addressing two review comments.
Changes:
Texture.destroy()no longer closes ImageBitmaps unconditionally; only when the owner has opted in viasetReleaseSourceAfterUpload(). Avoids invalidating bitmaps shared across textures or with caller code.releaseImageSources()now clears thereleaseSourceAfterUploadflag after running, matching the documented "release after the next upload" semantics. Callers must re-arm by callingsetReleaseSourceAfterUpload()again if they assign a new source they want released.