Skip to content

fix: ensure opacity dither fully hides at alpha 0 and fully shows at alpha 1 #8767

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mvaligursky merged 1 commit into from
May 22, 2026
Merged

fix: ensure opacity dither fully hides at alpha 0 and fully shows at alpha 1 #8767

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions src/scene/shader-lib/glsl/chunks/standard/frag/opacity-dither.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,6 +11,12 @@ uniform vec4 blueNoiseJitter;
#endif

void opacityDither(float alpha, float id) {
if (alpha <= 0.0)
discard;

if (alpha >= 1.0)
return;

#if STD_OPACITY_DITHER == BAYER8

float noise = bayer8(floor(mod(gl_FragCoord.xy + blueNoiseJitter.xy + id, 8.0))) / 64.0;
Expand Down
8 changes: 8 additions & 0 deletions src/scene/shader-lib/wgsl/chunks/standard/frag/opacity-dither.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,6 +12,14 @@ uniform blueNoiseJitter: vec4f;
#endif

fn opacityDither(alpha: f32, id: f32) {
if (alpha <= 0.0) {
discard;
}

if (alpha >= 1.0) {
return;
}

#if STD_OPACITY_DITHER == BAYER8

var noise: f32 = bayer8(floor((pcPosition.xy + uniform.blueNoiseJitter.xy + id) % vec2f(8.0))) / 64.0;
Expand Down