fix: support cross-origin example iframes#8768
Merged
Merged
Conversation
kpal81xd
force-pushed
the
fix/examples-iframe-cross-origin
branch
from
af0ca8c to
5bf0139
Compare
kpal81xd
force-pushed
the
fix/examples-iframe-cross-origin
branch
from
5bf0139 to
893f63b
Compare
kpal81xd
force-pushed
the
fix/examples-iframe-cross-origin
branch
from
893f63b to
67efef8
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Make direct example iframe routes safe to embed from another origin.
Public API Changes
None.
Testing
Manual tests:
/iframe/misc_hello-world.html?deviceType=webgl2from another local origin in Chromium and confirmedready=truewith zero SecurityError or permission errors.Checklist