fix(gsplat): make writeSortIndirectArgs WGSL helper portable for Firefox WebGPU#8784
Merged
Merged
Conversation
…fox WebGPU The helper took the indirect dispatch buffer as a ptr<storage, ...> parameter. Passing storage-space pointers across function boundaries requires the 'unrestricted_pointer_parameters' WGSL language feature, which Chrome (Dawn) enables by default but Firefox (naga) rejects with a shader validation error. Drop the pointer parameter and reference the global indirectDispatchArgs binding directly. Both call sites already used that exact binding name.
mvaligursky
added a commit
that referenced
this pull request
May 27, 2026
…fox WebGPU (#8784) The helper took the indirect dispatch buffer as a ptr<storage, ...> parameter. Passing storage-space pointers across function boundaries requires the 'unrestricted_pointer_parameters' WGSL language feature, which Chrome (Dawn) enables by default but Firefox (naga) rejects with a shader validation error. Drop the pointer parameter and reference the global indirectDispatchArgs binding directly. Both call sites already used that exact binding name. Co-authored-by: Martin Valigursky <mvaligursky@snapchat.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes a WebGPU shader validation error in the unified gsplat renderer that prevented Firefox from rendering splats (observed on supersp.at scenes).
The
writeSortIndirectArgsWGSL helper took the indirect dispatch buffer as aptr<storage, array<u32>, read_write>parameter. Passing storage-space pointers across function boundaries requires theunrestricted_pointer_parametersWGSL language feature, which Chrome (Dawn) enables by default but Firefox (naga) rejects:Changes:
sort-indirect-args.js: drop thebufpointer parameter; the helper now references the globalindirectDispatchArgsbinding directly. Added a comment documenting the contract (calling shader must declare aindirectDispatchArgsstorage binding) and the portability rationale.compute-gsplat-write-indirect-args.js/compute-gsplat-projector-write-indirect-args.js: updated the two call sites to drop the&indirectDispatchArgsargument. Both already used that exact binding name, so no rename was needed.Affected paths:
GSPLAT_RENDERER_COMPUTE(interval compaction)GSPLAT_RENDERER_RASTER_GPU_SORT(hybrid raster + projector)