fix(scene): fire EVENT_PRECULL after frustum update#8793
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reorder
cullCompositionsoEVENT_PRECULLis dispatched aftercamera.frameUpdateandupdateCameraFrustumhave run. Listeners now receive a camera whose frustum reflects the current frame's state, which makes the event usable for custom culling, LOD selection, and other logic that depends on up-to-date frustum planes.This also aligns behavior with the shadow renderer's
EVENT_PRECULLsite, which already fires after its frustum is updated.Fixes #8789.
Changes:
EVENT_PRECULLnow fires after the camera frustum has been recomputed for the frame.Behavior change:
EVENT_PRECULLfiring before the frustum update (e.g., to mutate the camera transform and have that change picked up by this frame's frustum) must now callRenderer#updateCameraFrustumthemselves, or move that logic earlier.