fix: include edgeId in SELECT_EDGE event payload#111
Merged
willeastcott merged 1 commit intomainfrom Mar 7, 2026
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Updates the graph’s UI event payload so external consumers (especially when passiveUIEvents: true) can identify the specific selected edge by id.
Changes:
- Add
edgeIdto theGRAPH_ACTIONS.SELECT_EDGECustomEvent payload dispatched fromcreateEdge.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
You can also share your feedback on Copilot code review. Take the survey.
willeastcott
force-pushed
the
fix/select-edge-edgeid
branch
3 times, most recently
from
18cfc81 to
f08920f
Compare
The SELECT_EDGE event was missing the edgeId, which meant consumers using passiveUIEvents could not identify which specific edge was selected (e.g. for keyboard-driven delete). Made-with: Cursor
willeastcott
force-pushed
the
fix/select-edge-edgeid
branch
from
f08920f to
435143d
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
edgeIdin theSELECT_EDGEevent payload dispatched fromcreateEdge{ edge, prevItem }without theedgeId, so consumers usingpassiveUIEventscould not identify which specific edge was selectedTest plan
passiveUIEvents: trueSELECT_EDGEevent payload includesedgeId