fix: default to building all targets when env.target is unset#131
Merged
willeastcott merged 1 commit intomainfrom Mar 8, 2026
Merged
fix: default to building all targets when env.target is unset#131willeastcott merged 1 commit intomainfrom
willeastcott merged 1 commit intomainfrom
Conversation
willeastcott
force-pushed
the
fix/rollup-default-target
branch
from
5574e3f to
f42d3a0
Compare
Made-with: Cursor
willeastcott
force-pushed
the
fix/rollup-default-target
branch
from
f42d3a0 to
f8d67fa
Compare
Contributor
There was a problem hiding this comment.
Pull request overview
Updates the Rollup configuration so running rollup -c without --environment target:... still produces a valid build by defaulting to all output targets, aligning the behavior with target:all.
Changes:
- Replaces the outer
if (process.env.target)guard with optional chaining in theswitch. - Adds a
defaultbranch that builds all targets (UMD, ESM, styles) whenprocess.env.targetis unset.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
You can also share your feedback on Copilot code review. Take the survey.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
process.env.targetis unsetdefaultcase, removing the outerifguardDetails
Previously, running
rollup -cwithout--environment target:...lefttargetsasundefined, causing Rollup to receive no configuration. Now it falls through to thedefaultcase and builds everything, matching the behavior oftarget:all.