Skip to content

Align build config with pcui#133

Merged
willeastcott merged 1 commit intomainfrom
refactor/align-build-with-pcui
Mar 8, 2026
Merged

Align build config with pcui#133
willeastcott merged 1 commit intomainfrom
refactor/align-build-with-pcui

Conversation

@willeastcott
Copy link
Copy Markdown
Contributor

Summary

  • Replace rollup-plugin-postcss with rollup-plugin-sass (using api: 'modern'), matching pcui's build approach and eliminating the Dart Sass legacy JS API deprecation warning
  • Add sourcemap: true to the umd and module rollup output configs, fixing the @rollup/plugin-typescript sourcemap warning
  • Remove the unused postcss plugin from the umd and module targets (SCSS is only imported in the dedicated styles entry point)
  • Net reduction of 74 transitive dependencies

Made-with: Cursor
@willeastcott willeastcott requested a review from Copilot March 8, 2026 15:47
@willeastcott willeastcott self-assigned this Mar 8, 2026
@willeastcott willeastcott added the enhancement New feature or request label Mar 8, 2026
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR aligns the library’s Rollup build pipeline with the approach used in pcui, primarily by switching the stylesheet build to rollup-plugin-sass (modern Sass API) and cleaning up sourcemap/plugin configuration across targets.

Changes:

  • Replace rollup-plugin-postcss with rollup-plugin-sass for the dedicated styles entry point (modern Sass API) to eliminate the Dart Sass legacy JS API deprecation warning.
  • Enable sourcemap: true for the UMD and ESM outputs to resolve the @rollup/plugin-typescript sourcemap warning.
  • Remove PostCSS processing from the UMD/ESM targets (SCSS is only imported via the separate styles build).

Reviewed changes

Copilot reviewed 2 out of 3 changed files in this pull request and generated no comments.

File Description
rollup.config.mjs Switch styles pipeline to rollup-plugin-sass, remove PostCSS from JS bundles, and enable sourcemaps for UMD/ESM outputs.
package.json Swap devDependency from rollup-plugin-postcss to rollup-plugin-sass.
package-lock.json Lockfile updates reflecting the dependency swap and reduced transitive dependency set.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

You can also share your feedback on Copilot code review. Take the survey.

@willeastcott willeastcott merged commit 333bb07 into main Mar 8, 2026
6 checks passed
@willeastcott willeastcott deleted the refactor/align-build-with-pcui branch March 8, 2026 15:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants