Align build config with pcui#133
Merged
willeastcott merged 1 commit intomainfrom Mar 8, 2026
Merged
Conversation
Made-with: Cursor
Contributor
There was a problem hiding this comment.
Pull request overview
This PR aligns the library’s Rollup build pipeline with the approach used in pcui, primarily by switching the stylesheet build to rollup-plugin-sass (modern Sass API) and cleaning up sourcemap/plugin configuration across targets.
Changes:
- Replace
rollup-plugin-postcsswithrollup-plugin-sassfor the dedicatedstylesentry point (modern Sass API) to eliminate the Dart Sass legacy JS API deprecation warning. - Enable
sourcemap: truefor the UMD and ESM outputs to resolve the@rollup/plugin-typescriptsourcemap warning. - Remove PostCSS processing from the UMD/ESM targets (SCSS is only imported via the separate
stylesbuild).
Reviewed changes
Copilot reviewed 2 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| rollup.config.mjs | Switch styles pipeline to rollup-plugin-sass, remove PostCSS from JS bundles, and enable sourcemaps for UMD/ESM outputs. |
| package.json | Swap devDependency from rollup-plugin-postcss to rollup-plugin-sass. |
| package-lock.json | Lockfile updates reflecting the dependency swap and reduced transitive dependency set. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
You can also share your feedback on Copilot code review. Take the survey.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
rollup-plugin-postcsswithrollup-plugin-sass(usingapi: 'modern'), matching pcui's build approach and eliminating the Dart Sass legacy JS API deprecation warningsourcemap: trueto theumdandmodulerollup output configs, fixing the@rollup/plugin-typescriptsourcemap warningumdandmoduletargets (SCSS is only imported in the dedicatedstylesentry point)