chore: set explicit rootDir in tsconfigs#539
Merged
Merged
Conversation
TypeScript 6 reports TS5011 ("The common source directory of
'tsconfig.json' is './src'. The 'rootDir' setting must be explicitly
set...") when @rollup/plugin-typescript invokes the compiler with an
inferred rootDir. Set rootDir explicitly to the value TS was already
inferring ("./src" for the main project, "../src" for the React
project) so the message goes away.
Verified on TS 5.9.3 that the emitted `types/` and `react/types/`
file listings are byte-identical before and after, so no
consumer-visible declaration shape changes.
Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
TypeScript 6 reports
TS5011when@rollup/plugin-typescriptinvokes the compiler with an inferredrootDir:Set
rootDirto the value TS was already inferring —"./src"for the main project,"../src"for the React project (relative toreact/tsconfig.json). On TS 5.9 this is a no-op. On TS 6 it silences the new TS5011 check so #538 can ship.Test plan
npm run build:typesclean.npm run build:es6clean.types/andreact/types/file listings are byte-identical before vs after (114 files, identical paths).After merge: Renovate's #538 will rebase and its CI should go green.
🤖 Generated with Claude Code