Update package metadata and repository links #119
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
marklundin
commented
Apr 28, 2025
marklundin
commented
- Added license information as "MIT" to both package.json files for compliance.
- Updated repository URLs to point to the main repository instead of specific directories, improving clarity and accessibility.
- Added license information as "MIT" to both package.json files for compliance. - Updated repository URLs to point to the main repository instead of specific directories, improving clarity and accessibility.
commit: |
| "name": "playcanvas-react-monorepo", | ||
| "description": "A monorepo for PlayCanvas React renderer and examples. Please see the packages directory for more information.", | ||
| "private": true, | ||
| "license": "MIT", |
Contributor
There was a problem hiding this comment.
Presumably you don't want the private field any more?
Collaborator
Author
There was a problem hiding this comment.
It's on the root monorepo package.json, which should be private, the library package.json is public though
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.