Skip to content

Conversation

@marklundin
Copy link
Collaborator

Fixes a CSS layout issue in the docs where the editor was blocking the orbit controls in the examples.

  • Removed unnecessary min-height from layout wrapper.
  • Updated Playground component to enhance responsiveness with dynamic height calculations.
  • Ensured pointer events are correctly managed for interactive elements.

…responsiveness

- Removed unnecessary min-height from layout wrapper.
- Updated Playground component to enhance responsiveness with dynamic height calculations.
- Ensured pointer events are correctly managed for interactive elements.
@marklundin marklundin self-assigned this Sep 3, 2025
@changeset-bot
Copy link

changeset-bot bot commented Sep 3, 2025

⚠️ No Changeset found

Latest commit: c751d10

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@marklundin marklundin requested a review from Copilot September 3, 2025 11:37
@pkg-pr-new
Copy link

pkg-pr-new bot commented Sep 3, 2025

Open in StackBlitz

npm i https://pkg.pr.new/@playcanvas/blocks@216
npm i https://pkg.pr.new/@playcanvas/react@216

commit: c751d10

This comment was marked as outdated.

@marklundin marklundin added documentation Improvements or additions to documentation chore and removed chore labels Sep 3, 2025
@marklundin marklundin changed the title Fixes examples blocked Orbit Controks Fixes examples blocked Orbit Controls Sep 3, 2025
@marklundin marklundin changed the title Fixes examples blocked Orbit Controls Fixes blocked Orbit Controls in Examples Sep 3, 2025
@marklundin marklundin requested a review from a team September 3, 2025 13:52
- Removed unnecessary pointer-events-none class from the Playground layout.
- Enhanced the styling of the Playground component for better visual consistency.
- Ensured proper handling of mouse events to prevent propagation.
@marklundin marklundin requested a review from Copilot September 3, 2025 14:05
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR fixes CSS layout issues preventing orbit controls from working properly in documentation examples by adjusting pointer event handling and container dimensions.

  • Removed unnecessary min-height from layout wrapper to prevent overflow issues
  • Updated Playground component with better responsive height calculations and pointer event management
  • Enhanced container sizing to work with dynamic viewport heights

Reviewed Changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.

File Description
packages/docs/app/layout.tsx Removed min-height constraint from main layout wrapper
packages/docs/app/[[...mdxPath]]/page.tsx Updated playground container height to use dynamic viewport calculation
packages/docs/docs-components/Playground.tsx Enhanced pointer event handling and container sizing for better responsiveness

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

@marklundin marklundin marked this pull request as ready for review September 5, 2025 15:52
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
@marklundin marklundin merged commit 0475a86 into main Sep 8, 2025
5 checks passed
@marklundin marklundin deleted the fix-examples-css-blocking branch September 8, 2025 13:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

documentation Improvements or additions to documentation

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants