-
Notifications
You must be signed in to change notification settings - Fork 33
Fixes blocked Orbit Controls in Examples #216
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
…responsiveness - Removed unnecessary min-height from layout wrapper. - Updated Playground component to enhance responsiveness with dynamic height calculations. - Ensured pointer events are correctly managed for interactive elements.
|
commit: |
- Removed unnecessary pointer-events-none class from the Playground layout. - Enhanced the styling of the Playground component for better visual consistency. - Ensured proper handling of mouse events to prevent propagation.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR fixes CSS layout issues preventing orbit controls from working properly in documentation examples by adjusting pointer event handling and container dimensions.
- Removed unnecessary min-height from layout wrapper to prevent overflow issues
- Updated Playground component with better responsive height calculations and pointer event management
- Enhanced container sizing to work with dynamic viewport heights
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| packages/docs/app/layout.tsx | Removed min-height constraint from main layout wrapper |
| packages/docs/app/[[...mdxPath]]/page.tsx | Updated playground container height to use dynamic viewport calculation |
| packages/docs/docs-components/Playground.tsx | Enhanced pointer event handling and container sizing for better responsiveness |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Fixes a CSS layout issue in the docs where the editor was blocking the orbit controls in the examples.