Clean up logging and refactor HTML viewer settings#174
Merged
slimbuck merged 5 commits intoplaycanvas:mainfrom Mar 10, 2026
Merged
Clean up logging and refactor HTML viewer settings#174slimbuck merged 5 commits intoplaycanvas:mainfrom
slimbuck merged 5 commits intoplaycanvas:mainfrom
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR cleans up logging output across the codebase and refactors the HTML viewer settings handling. Internal diagnostic messages are moved from logger.log to logger.debug, redundant log messages are removed, and message casing is normalized. The voxel writer progress reporting is simplified from 7 steps to 4. The HTML writer is refactored to replace a typed ViewerSettings interface and manual shallow-merge with a defaultSettings constant matching the viewer v2 schema.
Changes:
- Standardize logging: move verbose stats to
logger.debug, remove GPU adapter/octree profiling messages, normalize message casing - Consolidate voxel writer progress from 7 named phases to 4 (Building BVH → Voxelizing → Filtering → Writing)
- Refactor HTML writer to use a
defaultSettingsconst (viewer v2 schema) instead of aViewerSettingstype with manual merge
Reviewed changes
Copilot reviewed 8 out of 8 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
src/lib/writers/write-voxel.ts |
Reduce progress steps from 7 to 4, move/remove verbose log messages |
src/lib/writers/write-html.ts |
Replace ViewerSettings type and merge logic with defaultSettings const and direct passthrough |
src/lib/voxel/voxel-filter.ts |
Change filter stats from logger.log to logger.debug |
src/lib/voxel/sparse-octree.ts |
Remove octree profiling debug output |
src/lib/spatial/k-means.ts |
Normalize log message casing (uppercase → lowercase) |
src/lib/data-table/morton-order.ts |
Remove commented-out debug line |
src/cli/node-device.ts |
Remove "Using GPU" log message |
src/cli/index.ts |
Rephrase loaded gaussians message |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
logger.logtologger.debug, remove redundant messages (GPU adapter name, octree profiling), and normalize message casingChanges
Logging
write-voxel.ts: Reduce progress steps from 7 to 4; move verbose stats tologger.debugor removevoxel-filter.ts:logger.log→logger.debugfor filter statssparse-octree.ts: Remove octree profiling debug outputnode-device.ts: Remove "Using GPU" logcli/index.ts: Rephrase loaded gaussians messagek-means.ts: Normalize log message casingmorton-order.ts: Remove commented-out debug lineHTML writer
write-html.ts: ReplaceViewerSettingstype and manual default-merging with adefaultSettingsconst and direct passthrough of caller-provided settings