Handle extreme outliers in 1D quantization by rebuilding histogram over trimmed range#190
Merged
slimbuck merged 4 commits intoplaycanvas:mainfrom Mar 23, 2026
Merged
Handle extreme outliers in 1D quantization by rebuilding histogram over trimmed range#190slimbuck merged 4 commits intoplaycanvas:mainfrom
slimbuck merged 4 commits intoplaycanvas:mainfrom
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates the 1D quantizer’s histogram pre-processing to better handle datasets with extreme outliers that otherwise make the histogram too sparse to support k distinct centroids.
Changes:
- Detects when the initial histogram has fewer non-empty bins than
k, and rebuilds the histogram over a percentile-trimmed range. - Clamps values outside the trimmed range into the edge bins so outliers still contribute without dominating histogram range.
- Recomputes bin centers, weights, and prefix sums after rebuilding before running the DP solver.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Contributor
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 1 out of 1 changed files in this pull request and generated 4 comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Technical Details
The
quantize1dfunction builds a 1024-bin histogram betweendataMinanddataMax, then uses DP to find optimal centroids. When a handful of extreme outliers inflate the range, nearly all values cluster into a tiny fraction of the bins, leaving most bins empty. IfnonEmpty < k, the DP cannot producekdistinct centroids, resulting in a degraded codebook.The fix detects this condition after the initial histogram build and, when triggered:
newMin/newMaxfrom those binscounts,sums,centers,weights, and all prefix-sum arrays over the tighter rangenonEmptybefore proceeding to the DP solverValues outside the trimmed range are clamped to bin 0 or bin H-1, preserving their contribution without wasting resolution on near-empty stretches of the number line.
Test Plan
nonEmpty >= k)