Prebuild Publishing Targets to Miinimize Chances of Releases Breaking#650
Merged
KetanReddy merged 3 commits intomainfrom Jun 10, 2025
Merged
Prebuild Publishing Targets to Miinimize Chances of Releases Breaking#650KetanReddy merged 3 commits intomainfrom
KetanReddy merged 3 commits intomainfrom
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #650 +/- ##
==========================================
- Coverage 90.39% 90.38% -0.01%
==========================================
Files 333 333
Lines 20564 20564
Branches 1987 1987
==========================================
- Hits 18588 18587 -1
- Misses 1962 1963 +1
Partials 14 14 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Member
Author
|
/canary |
sugarmanz
reviewed
Jun 10, 2025
| MVN_RELEASE_TYPE=release | ||
| fi | ||
|
|
||
| # Android/JVM Prepublish |
Member
There was a problem hiding this comment.
Can merge this comment w/ the Maven Central Prepublish comment — they're the same thing.
| fi | ||
|
|
||
| # Android/JVM Prepublish | ||
| echo "Publishing Maven Packages with release type: ${MVN_RELEASE_TYPE} on branch: ${CURRENT_BRANCH}" |
Member
There was a problem hiding this comment.
Should move the echos until where we actually publish
| # Running this here because it will still have the pre-release version in the VERSION file before auto cleans it up | ||
| # Make sure to re-stamp the outputs with the BASE_PATH so nextjs knows what to do with links | ||
| # Docs Prepublish | ||
| bazel build --config=release //docs/... |
Member
There was a problem hiding this comment.
Should build the explicit target that we're going to run, //docs:gh_deploy — not everything under docs, as it might not all be applicable for publishing docs.
sugarmanz
approved these changes
Jun 10, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Change Type (required)
Indicate the type of change your pull request is:
patchminormajorN/ADoes your PR have any documentation updates?
📦 Published PR as canary version:
0.11.1--canary.650.22896Try this version out locally by upgrading relevant packages to 0.11.1--canary.650.22896