Fix transforms on assets with applicability#668
Conversation
applicability
| export { default as SwitchPlugin } from "./switch"; | ||
| export { default as MultiNodePlugin } from "./multi-node"; | ||
| export { default as AssetPlugin } from "./asset"; | ||
| export * from "./asset-transform"; |
There was a problem hiding this comment.
Do we need a star export here if there is only one exported target from this file?
There was a problem hiding this comment.
Also, maybe a question for another time, but all the other internal plugins are default exports, should this follow suite for consistency or should we change them all now?
There was a problem hiding this comment.
I thought we were doing away w/ default exports — so, I left as-is even though it didn't follow the other plugins. I don't care one way or another, I'll just change it for consistency and we can revert the commit otherwise.
There was a problem hiding this comment.
Yeah I'd say we probably should update these as well. I can make an issue for that.
|
/canary |
|
/canary |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #668 +/- ##
==========================================
- Coverage 90.25% 90.24% -0.01%
==========================================
Files 333 333
Lines 20606 20605 -1
Branches 1992 1991 -1
==========================================
- Hits 18597 18595 -2
- Misses 1993 1994 +1
Partials 16 16 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Will close #667
Change Type (required)
Indicate the type of change your pull request is:
patchminormajorN/ADoes your PR have any documentation updates?
Release Notes
Move
AssetTransformCorePluginapplication afterapplicabilityandswitchview plugins to ensure transforms properly apply to conditional assets.📦 Published PR as canary version:
0.11.3--canary.668.23668Try this version out locally by upgrading relevant packages to 0.11.3--canary.668.23668