Revert "Asset deprecation (#639)" + add async hydration tracker plugin as default#676
Merged
Revert "Asset deprecation (#639)" + add async hydration tracker plugin as default#676
Conversation
sugarmanz
force-pushed
the
fix-async-tracker-logs
branch
from
e9bc561 to
162f4fc
Compare
sugarmanz
force-pushed
the
fix-async-tracker-logs
branch
2 times, most recently
from
cb285f0 to
ef39da2
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #676 +/- ##
=======================================
Coverage 90.36% 90.36%
=======================================
Files 333 333
Lines 20654 20654
Branches 2010 2010
=======================================
Hits 18664 18664
Misses 1974 1974
Partials 16 16 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
sugarmanz
force-pushed
the
fix-async-tracker-logs
branch
from
b165e86 to
2f63369
Compare
sugarmanz
commented
Jul 9, 2025
Comment on lines
+117
to
+123
| androidPlayer.hooks.viewController.tap { viewController -> | ||
| viewController?.hooks?.view?.tap { view -> | ||
| view?.hooks?.onUpdate?.tap { _ -> | ||
| synchronized(trackedHydrations) { | ||
| trackedHydrations.clear() | ||
| } | ||
| } |
Member
Author
There was a problem hiding this comment.
Unfortunately, androidPlayer.onUpdate triggers asset decoding logic, which isn't needed for this plugin and causes some redundant logs. This is more verbose, but more targeted and trims redundant operations. Really, it would be great to encapsulate the asset decoding lifecycle as another hook to tap.
sugarmanz
commented
Jul 9, 2025
| fun basic() { | ||
| launchMock("badge-all") | ||
|
|
||
| androidComposeRule.waitForIdle() |
sugarmanz
changed the title
Member
Author
|
/canary |
Member
|
Are we aware of why the deprecation in #639 was a performance detractor? |
KetanReddy
approved these changes
Jul 10, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Since
SuspendableAssetwas deprecated (in #639), consumers will need to add aAsyncHydrationTrackerPluginto enable tracking of asset rendering state. This plugin is used directly inDecodableAssetcode, and if it's not found, will log a warning. It's not a real warning, and should be disabled to limit noise in logs. We could enable conditional logging infindPlugin, or makeAsyncHydrationTrackerPlugina default plugin — for the sake of simplicity, this PR opts for the latter.Unfortunately, through integration, #639 was identified as a performance detractor (opened #678). This PR also reverts that change to the original API, which would be a breaking change.
Change Type (required)
Indicate the type of change your pull request is:
patchminormajorN/ADoes your PR have any documentation updates?
Release Notes
AsyncHydrationTrackerPluginis now a defaultAndroidPlayerPlugin📦 Published PR as canary version:
0.12.0--canary.676.24246Try this version out locally by upgrading relevant packages to 0.12.0--canary.676.24246