Fix default-view-plugin sort order#679
Merged
spentacular merged 5 commits intomainfrom Jul 10, 2025
Merged
Conversation
…r applied plugins come after
Member
Author
|
/canary |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #679 +/- ##
=======================================
Coverage 90.36% 90.36%
=======================================
Files 333 333
Lines 20654 20656 +2
Branches 2010 2011 +1
=======================================
+ Hits 18664 18666 +2
Misses 1974 1974
Partials 16 16 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
…om/player-ui/player into fix-default-view-plugin-sort-order
Member
Author
|
/canary |
Member
|
/canary |
sugarmanz
approved these changes
Jul 10, 2025
KetanReddy
approved these changes
Jul 10, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently the plugins from
default-view-pluginare applied after user applied plugins. Looking further, theviewControlleris tapped before it'scall-ed, so any hooks fromplayer.hooks.viewwill be tapped first. By tapping thethis.hookswe can ensure the internal plugins are applied first.Change Type (required)
Indicate the type of change your pull request is:
patchminormajorN/ADoes your PR have any documentation updates?
Release Notes
Change how
player.hooks.viewcallis handled to ensure tap order comes from default plugins first.📦 Published PR as canary version:
0.12.0--canary.679.24349Try this version out locally by upgrading relevant packages to 0.12.0--canary.679.24349