Skip to content

Fix default-view-plugin sort order#679

Merged
spentacular merged 5 commits intomainfrom
fix-default-view-plugin-sort-order
Jul 10, 2025
Merged

Fix default-view-plugin sort order#679
spentacular merged 5 commits intomainfrom
fix-default-view-plugin-sort-order

Conversation

@spentacular
Copy link
Copy Markdown
Member

@spentacular spentacular commented Jul 10, 2025

Currently the plugins from default-view-plugin are applied after user applied plugins. Looking further, the viewController is tapped before it's call-ed, so any hooks from player.hooks.view will be tapped first. By tapping the this.hooks we can ensure the internal plugins are applied first.

Change Type (required)

Indicate the type of change your pull request is:

  • patch
  • minor
  • major
  • N/A

Does your PR have any documentation updates?

  • Updated docs
  • No Update needed
  • Unable to update docs

Release Notes

Change how player.hooks.view call is handled to ensure tap order comes from default plugins first.

📦 Published PR as canary version: 0.12.0--canary.679.24349

Try this version out locally by upgrading relevant packages to 0.12.0--canary.679.24349

@spentacular spentacular requested a review from KetanReddy as a code owner July 10, 2025 05:40
@spentacular
Copy link
Copy Markdown
Member Author

/canary

@codecov
Copy link
Copy Markdown

codecov Bot commented Jul 10, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 90.36%. Comparing base (7bf3cf8) to head (406a7ed).
Report is 2 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #679   +/-   ##
=======================================
  Coverage   90.36%   90.36%           
=======================================
  Files         333      333           
  Lines       20654    20656    +2     
  Branches     2010     2011    +1     
=======================================
+ Hits        18664    18666    +2     
  Misses       1974     1974           
  Partials       16       16           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@spentacular
Copy link
Copy Markdown
Member Author

/canary

@sugarmanz
Copy link
Copy Markdown
Member

/canary

@spentacular spentacular enabled auto-merge (squash) July 10, 2025 18:28
@spentacular spentacular merged commit 039671b into main Jul 10, 2025
11 checks passed
@spentacular spentacular deleted the fix-default-view-plugin-sort-order branch July 10, 2025 18:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants